linux-kernel - Re: [PATCH net-next resend 10/13] debugfs: constify argument to debugfs_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2016 15:25:59 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, Nicolai Stange <nicstange@...il.com>,
        Christian Lamparter <chunkeey@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next resend 10/13] debugfs: constify argument to
 debugfs_real_fops()

On Thu, Nov 03, 2016 at 05:12:06PM +0000, Jakub Kicinski wrote:
> seq_file users can only access const version of file pointer,
> because the ->file member of struct seq_operations is marked
> as such.  Make parameter to debugfs_real_fops() const.
> 
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Nicolai Stange <nicstange@...il.com>
> CC: Christian Lamparter <chunkeey@...il.com>
> CC: LKML <linux-kernel@...r.kernel.org>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  include/linux/debugfs.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
> index 4d3f0d1aec73..bf1907d96097 100644
> --- a/include/linux/debugfs.h
> +++ b/include/linux/debugfs.h
> @@ -52,7 +52,8 @@ struct debugfs_regset32 {
>   * Must only be called under the protection established by
>   * debugfs_use_file_start().
>   */
> -static inline const struct file_operations *debugfs_real_fops(struct file *filp)
> +static inline const struct file_operations *
> +debugfs_real_fops(const struct file *filp)

Ick.  Tell me that looks better :(

Please just don't wrap things like that, just make it go longer than 80
columns, I can handle the complaints...

thanks,

greg k-h