linux-kernel - Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 14:46:51 +0100
From:   Christian König <christian.koenig@....com>
To:     Geliang Tang <geliangtang@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo_update

Am 11.11.2016 um 13:26 schrieb Geliang Tang:
> Use list_move() instead of list_del() + list_add() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@...il.com>

Reviewed-by: Christian König <christian.koenig@....com>.

> ---
>   drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index a135874..2f1e372 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
>   		}
>   		list_del_init(&bo_va->vm_status);
>   	} else {
> -		list_del(&bo_va->vm_status);
> -		list_add(&bo_va->vm_status, &vm->cleared);
> +		list_move(&bo_va->vm_status, &vm->cleared);
>   	}
>   	spin_unlock(&vm->status_lock);
>