linux-kernel - Re: [PATCH v14 5/9] clocksource/drivers/arm_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 21:55:03 +0800
From:   Hanjun Guo <hanjun.guo@...aro.org>
To:     Mark Rutland <mark.rutland@....com>, fu.wei@...aro.org
CC:     linaro-acpi@...ts.linaro.org, catalin.marinas@....com,
        will.deacon@....com, linux-kernel@...r.kernel.org,
        julien.grall@....com, wei@...hat.com, lorenzo.pieralisi@....com,
        al.stone@...aro.org, tn@...ihalf.com, timur@...eaurora.org,
        daniel.lezcano@...aro.org, linux-acpi@...r.kernel.org,
        linux@...ck-us.net, lenb@...nel.org, harba@...eaurora.org,
        linux-watchdog@...r.kernel.org, arnd@...db.de,
        marc.zyngier@....com, jcm@...hat.com, sudeep.holla@....com,
        cov@...eaurora.org, tglx@...utronix.de,
        linux-arm-kernel@...ts.infradead.org, graeme.gregory@...aro.org,
        rjw@...ysocki.net, rruigrok@...eaurora.org, leo.duran@....com,
        Suravee.Suthikulpanit@....com, wim@...ana.be,
        christoffer.dall@...aro.org
Subject: Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify
 ACPI support code.

On 10/21/2016 07:21 PM, Mark Rutland wrote:
> On Fri, Oct 21, 2016 at 12:14:01PM +0100, Mark Rutland wrote:
>> On Thu, Oct 20, 2016 at 05:58:17PM +0100, Mark Rutland wrote:
>>> On Thu, Sep 29, 2016 at 02:17:13AM +0800, fu.wei@...aro.org wrote:
>>>> +	arch_timer_ppi[PHYS_NONSECURE_PPI] = acpi_gtdt_map_ppi(PHYS_NONSECURE_PPI);
>>>> +	arch_timer_ppi[VIRT_PPI] = acpi_gtdt_map_ppi(VIRT_PPI);
>>>> +	arch_timer_ppi[HYP_PPI] = acpi_gtdt_map_ppi(HYP_PPI);
>>>> +	/* Always-on capability */
>>>> +	arch_timer_c3stop = acpi_gtdt_c3stop();
>>>
>>> ... I think we should check the flag on the relevant interrupt, though
>>> that's worth clarifying.
>>
>> I see I misread the spec; this is part of the common flags.
>>
>> Please ignore this point; sorry for the noise.
>
> Actually, I misread the spec this time around; the flag *can* differ per
> interrupt for the sysreg/cp15 timer, but not for the MMIO timers where
> the flag is in a common field.
>
> So please *do* consider the above.

Sorry, misread the email as well...

Check the spec again and it's per interrupt flag.

Thanks
Hanjun