[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 Nov 2016 12:35:13 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Petr Mladek <pmladek@...e.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Joe Perches <joe@...ches.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
Jason Wessel <jason.wessel@...driver.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Chris Mason <clm@...com>,
Josef Bacik <jbacik@...com>, David Sterba <dsterba@...e.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] printk/kdb: Handle more message headers
On Wed, 9 Nov 2016 13:41:29 +0100
Petr Mladek <pmladek@...e.com> wrote:
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index eac1af8502bb..a0859e169bc3 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -31,6 +31,14 @@ static inline const char *printk_skip_level(const char *buffer)
> return buffer;
> }
>
> +static inline const char *printk_skip_headers(const char *buffer)
> +{
> + while (printk_get_level(buffer))
> + buffer = printk_skip_level(buffer);
Hmm, shouldn't there be a length passed in here. What happens if buffer
ends with a header. Can't this overflow?
-- Steve
> +
> + return buffer;
> +}
> +
> #define CONSOLE_EXT_LOG_MAX 8192
>
Powered by blists - more mailing lists