linux-kernel - Re: [PATCH 1/2] watchdog: bcm7038

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 11:47:08 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload

Hi Javier,

On Fri, Nov 11, 2016 at 04:43:37PM -0300, Javier Martinez Canillas wrote:
> Hello Guenter,
> 
> On 10/14/2016 01:55 PM, Guenter Roeck wrote:
> > On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote:
> >> If the driver is built as a module, autoload won't work because the module
> >> alias information is not filled. So user-space can't match the registered
> >> device with the corresponding module.
> >>
> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> >>
> >> Before this patch:
> >>
> >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
> >> $
> >>
> >> After this patch:
> >>
> >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
> >> alias:          of:N*T*Cbrcm,bcm7038-wdtC*
> >> alias:          of:N*T*Cbrcm,bcm7038-wdt
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> > 
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > 
> 
> Are you going to pick this (and patch 2/2)?
> 
> I'm asking because you provided your r-b tag but the patch
> was never merged, so I wonder who should I ping about it.
> 
Wim would be the one to pick it.

Maybe it got lost.  I hope I'll find some time during the weekend
to update my tracking branch.

Guenter