linux-kernel - Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 21:31:09 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Felipe Balbi <felipe.balbi@...ux.intel.com>
Cc:     Sriram Dash <sriram.dash@....com>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, mathias.nyman@...el.com,
        gregkh@...uxfoundation.org, suresh.gupta@....com,
        stern@...land.harvard.edu, pku.leo@...il.com
Subject: Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
> > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> >  void dwc3_host_exit(struct dwc3 *dwc)
> >  {
> >       phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > -                       dev_name(&dwc->xhci->dev));
> > +                       dev_name(dwc->dev));
> >       phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
> > -                       dev_name(&dwc->xhci->dev));
> > +                       dev_name(dwc->dev));
> 
> this looks unrelated to $subject. Care to explain?

bus->sysdev is used for retrieving any information that comes from
the platform (DT or otherwise), and the phy lookup in has to be done
through sysdev as well because the platform cannot add it to
the child device it has no knowledge of.

When we set the sysdev to the parent, the phy lookup has to be
added to that device as well, rather than the child device.

	Arnd