linux-kernel - Re: [PATCH] Block: mtip32xx: Improvement in code readability when memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 13:37:35 -0700
From:   Jens Axboe <axboe@...com>
To:     Sachin Shukla <sachin.s5@...sung.com>,
        Asai Thambi SP <asamymuthupa@...ron.com>,
        Selvan Mani <smani@...ron.com>,
        "Rajesh Kumar Sambandam" <rsambandam@...ron.com>,
        Vignesh Gunasekaran <vgunasekaran@...ron.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        <linux-kernel@...r.kernel.org>, <sachiniiitm@...il.com>
CC:     <ravikant.s2@...sung.com>, <p.shailesh@...sung.com>,
        <ashish.kalra@...sung.com>, <vidushi.koul@...sung.com>
Subject: Re: [PATCH] Block: mtip32xx: Improvement in code readability when
 memdup_user() fails.

On 11/11/2016 02:04 AM, Sachin Shukla wrote:
> From: "Sachin Shukla" <sachin.s5@...sung.com>
>
> There is no need to call kfree() if memdup_user() fails, as no memory
> was allocated and the error in the error-valued pointer should be returned.

Applied for 4.10, thanks.

-- 
Jens Axboe