linux-kernel - Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Nov 2016 13:30:21 -0800
From:   Sarangdhar Joshi <spjoshi@...eaurora.org>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Trilok Soni <tsoni@...eaurora.org>
Subject: Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when
 devm_clk_get fails

On 11/09/2016 05:49 PM, Stephen Boyd wrote:
> On 11/03, Sarangdhar Joshi wrote:
>> When devm_clk_get fails for core clock, the failure was ignored
>> and the core_clk was explicitly set to NULL so that other
>> remaining clocks can be queried. However, now that we have a
>> cleaner way of expressing the clock dependency, return failure
>> when devm_clk_get fails for core clock.
>>
>> Signed-off-by: Sarangdhar Joshi <spjoshi@...eaurora.org>
>
> Why can't this be folded into the second patch? It seems
> incorrect to allow it to silently work in patch 2 even though
> we've flagged that clk as a requirement and then change that
> behavior here.
>

The idea was keep it separate so that if someone needs to keep earlier 
behavior (of ignoring the core clock failure), then it would be easier 
to just revert this commit and still use flag mechanism. Also convenient 
with git bisect for finding offending commit. I don't mind squashing 
this into patch 2 if we think that's better.

Regards,
Sarang

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project