linux-kernel - Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 10:00:14 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write

Hi Stephen,

On Wed, Nov 16, 2016 at 12:29 AM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> On 11/15, Vivek Gautam wrote:
>> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev)
>>  static struct nvmem_config econfig = {
>>       .name = "qfprom",
>>       .owner = THIS_MODULE,
>> -     .stride = 4,
>> +     .stride = 1,
>
> Are we certain that all qfproms support byte accesses?

I have tested on 8916 and 8996. Will give a try on older targets as
well.

For a note: we had been using the reg_stride = 1, before removing
regmap support for nvmem access [1].

[1] 382c62f nvmem: qfprom: remove nvmem regmap dependency


Thanks
Vivek

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project