linux-kernel - Re: [GIT PULL] fbdev fixes for 4.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 17:15:40 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Tomi Valkeinen <tomi.valkeinen@...com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-fbdev <linux-fbdev@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Mathieu Malaterre <malat@...ian.org>
Subject: Re: [GIT PULL] fbdev fixes for 4.9

Tomi Valkeinen <tomi.valkeinen@...com> writes:

> [ Unknown signature status ]
> On 14/11/16 18:25, Linus Torvalds wrote:
>> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@...com> wrote:
>>>
>>> Please pull two fbdev fixes for 4.9.
>> 
>> No.
>> 
>> This has obviously never even been test-compiled. It introduces two
>> new annoying warnings.
>
> Sorry about that. I dropped the patch for now and here's a new pull request.
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds.

You can turn it on per-directory, eg:

diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index ee8c81405a7f..2ee96810d26d 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -4,6 +4,8 @@
 
 # Each configuration option enables a list of files.
 
+subdir-ccflags-y := -Werror
+
 obj-y				+= core/
 
 obj-$(CONFIG_FB_MACMODES)      += macmodes.o


cheers