linux-kernel - Re: [PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2016 18:07:40 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sriram Dash <sriram.dash@....com>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        mark.rutland@....com, kishon@...com, catalin.marinas@....com,
        will.deacon@....com, stern@...land.harvard.edu, pku.leo@...il.com,
        mathias.nyman@...el.com, gregkh@...uxfoundation.org,
        suresh.gupta@....com, felipe.balbi@...ux.intel.com
Subject: Re: [PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver
 support

On Mon, Nov 14, 2016 at 10:56:54AM +0530, Sriram Dash wrote:
> Adds qoriq usb 3.0 phy driver support for LS1043A platform.
> Describes the qoriq usb 2.0 phy driver binding, currently used
> for LS1043A platform.
> 
> Signed-off-by: Sriram Dash <sriram.dash@....com>
> ---
>  .../devicetree/bindings/phy/phy-qoriq-usb3.txt     |  36 ++++
>  drivers/phy/Kconfig                                |   8 +
>  drivers/phy/Makefile                               |   1 +
>  drivers/phy/phy-qoriq-usb3.c                       | 202 +++++++++++++++++++++
>  4 files changed, 247 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt
>  create mode 100644 drivers/phy/phy-qoriq-usb3.c
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt b/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt
> new file mode 100644
> index 0000000..d934c80
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt
> @@ -0,0 +1,36 @@
> +Driver for Freescale USB 3.0 PHY
> +
> +Required properties:
> +
> +- compatible :	fsl,qoriq-usb3-phy
> +- reg :		register mappings for Parameter Configuration Register
> +		and Phy base offset.
> +- reg-names :	"param_ctrl" and "phy_base"
> +- phy_type :	For multi port host USB controllers, should be one of
> +		"ulpi", or "serial". For dual role USB controllers,
> +		should be one of "ulpi", "utmi", "utmi_wide", or "serial".

Do any of these really apply to a USB3 PHY?

Rob

> +
> +Example:
> +		usbphy0: usb3-phy@...F0000 {

usb-phy@...

> +                        compatible = "fsl,qoriq-usb3-phy";
> +                        reg = <0x0 0x01570070 0x0 0xC>, <0x0 0x084F0000 0x0 0x5000>;
> +                        reg-names = "param_ctrl", "phy_base";
> +                        #phy-cells = <0>;
> +                        phy_type = "utmi";
> +                };
> +
> +                usbphy1: usb3-phy@...00000 {
> +                        compatible = "fsl,qoriq-usb3-phy";
> +                        reg = <0x0 0x0157007C 0x0 0xC>, <0x0 0x08500000 0x0 0x5000>;
> +                        reg-names = "param_ctrl", "phy_base";
> +                        #phy-cells = <0>;
> +                        phy_type = "utmi";
> +                };
> +
> +                usbphy2: usb3-phy@...10000 {
> +                        compatible = "fsl,qoriq-usb3-phy";
> +                        reg = <0x0 0x01570088 0x0 0xC>, <0x0 0x08510000 0x0 0x5000>;
> +                        reg-names = "param_ctrl", "phy_base";
> +                        #phy-cells = <0>;
> +                        phy_type = "utmi";
> +                };