linux-kernel - Re: [PATCH 1/2] ovl: use kernel facility for copying attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 10:23:11 +0100
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Quorum Laval <quorum.laval@...il.com>
Cc:     "linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ovl: use kernel facility for copying attributes

On Tue, Nov 15, 2016 at 5:54 PM, Quorum Laval <quorum.laval@...il.com> wrote:
> Replace ovl_copyattr() by fsstack_copy_attr_all() and drop the definition of
> the former.

This isn't trivially correct, fsstack_copy_attr_all() copies more than
ovl_copyattr().   We need a better explanation for why it is correct
to copy all the other attributes as well.

Thanks,
Miklos