linux-kernel - Re: [PATCH -next] Input: gpio_keys: set input direction explicitly for gpio keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 20:48:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     kbuild-all@...org, linux-input@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH -next] Input: gpio_keys: set input direction explicitly
 for gpio keys

Hi Sudeep,

[auto build test ERROR on next-20161116]

url:    https://github.com/0day-ci/linux/commits/Sudeep-Holla/Input-gpio_keys-set-input-direction-explicitly-for-gpio-keys/20161116-202319
config: x86_64-randconfig-x017-201646 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/input/keyboard/gpio_keys.c: In function 'gpio_keys_setup_key':
>> drivers/input/keyboard/gpio_keys.c:506:4: error: 'flags' undeclared (first use in this function)
       flags |= GPIOF_ACTIVE_LOW;
       ^~~~~
   drivers/input/keyboard/gpio_keys.c:506:4: note: each undeclared identifier is reported only once for each function it appears in

vim +/flags +506 drivers/input/keyboard/gpio_keys.c

700a38b2 Dmitry Torokhov    2016-10-19  500  	} else if (gpio_is_valid(button->gpio)) {
5feeca3c Geert Uytterhoeven 2016-10-19  501  		/*
5feeca3c Geert Uytterhoeven 2016-10-19  502  		 * Legacy GPIO number, so request the GPIO here and
5feeca3c Geert Uytterhoeven 2016-10-19  503  		 * convert it to descriptor.
5feeca3c Geert Uytterhoeven 2016-10-19  504  		 */
5feeca3c Geert Uytterhoeven 2016-10-19  505  		if (button->active_low)
5feeca3c Geert Uytterhoeven 2016-10-19 @506  			flags |= GPIOF_ACTIVE_LOW;
bc8f1eaf Ben Dooks          2009-11-10  507  
5feeca3c Geert Uytterhoeven 2016-10-19  508  		error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
5feeca3c Geert Uytterhoeven 2016-10-19  509  					      desc);

:::::: The code at line 506 was first introduced by commit
:::::: 5feeca3c1e39c01f9ef5abc94dea94021ccf94fc Input: gpio_keys - add support for GPIO descriptors

:::::: TO: Geert Uytterhoeven <geert+renesas@...der.be>
:::::: CC: Dmitry Torokhov <dmitry.torokhov@...il.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27800 bytes)