linux-kernel - Re: [PATCH] zram: Fix unbalanced idr management at hot removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 10:22:12 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Takashi Iwai <tiwai@...e.de>, Nitin Gupta <ngupta@...are.org>,
        David Disseldorp <ddiss@...e.de>,
        <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH] zram: Fix unbalanced idr management at hot removal

Hi Sergey,

On Tue, Nov 22, 2016 at 10:09:30AM +0900, Sergey Senozhatsky wrote:
> Cc Andrew
> 
> On (11/22/16 09:11), Minchan Kim wrote:
> [..]
> > > This patch adds the proper error check in hot_remove_store() not to
> > > call idr_remove() unconditionally.
> > > 
> > > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1010970
> > > Reported-and-tested-by: David Disseldorp <ddiss@...e.de>
> > > Reviewed-by: David Disseldorp <ddiss@...e.de>
> > > Cc: <stable@...r.kernel.org>
> > > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> 
> 
> > Acked-by: Minchan Kim <minchan@...nel.org>
> 
> Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@...e.de
> Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> Cc: <stable@...r.kernel.org>    [4.5+]

17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
4.2+.

Thanks.

> 
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 

> 	-ss