linux-kernel - Re: [Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 12:31:50 -0200
From:   Mauro Carvalho Chehab <mchehab@...pensource.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     Tvrtko Ursulin <tursulin@...ulin.net>,
        Intel-gfx@...ts.freedesktop.org,
        Tomasz Stanislawski <t.stanislaws@...sung.com>,
        Pawel Osciak <pawel@...iak.com>, linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Matt Porter <mporter@...nel.crashing.org>,
        linux-media@...r.kernel.org,
        Alexandre Bounine <alexandre.bounine@....com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in
 sg_alloc_table_from_pages

Em Mon, 14 Nov 2016 09:55:48 +0000
Chris Wilson <chris@...is-wilson.co.uk> escreveu:

> On Fri, Nov 11, 2016 at 08:50:17AM +0000, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
> > 
> > Scatterlist entries have an unsigned int for the offset so
> > correct the sg_alloc_table_from_pages function accordingly.
> > 
> > Since these are offsets withing a page, unsigned int is
> > wide enough.
> > 
> > Also converts callers which were using unsigned long locally
> > with the lower_32_bits annotation to make it explicitly
> > clear what is happening.
> > 
> > v2: Use offset_in_page. (Chris Wilson)
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
> > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > Cc: Pawel Osciak <pawel@...iak.com>
> > Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > Cc: Tomasz Stanislawski <t.stanislaws@...sung.com>
> > Cc: Matt Porter <mporter@...nel.crashing.org>
> > Cc: Alexandre Bounine <alexandre.bounine@....com>
> > Cc: linux-media@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Acked-by: Marek Szyprowski <m.szyprowski@...sung.com> (v1)  
> 
> If there were kerneldoc, it would nicely explain that having an offset
> larger then a page is silly when passing in array of pages.
> 
> Changes elsewhere look ok (personally I'd be happy with just
> offset_in_page(), 4GiB superpages are somebody else's problem :)

For the media changes, that looked OK. We don't have any needs
to stream 4GB images nowadays :-)

Reviewed-by: Mauro Carvalho Chehab <mchehab@...pensource.com>
 
> Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
> -Chris
> 


Thanks,
Mauro