linux-kernel - Re: [PATCH v6 2/2] console: Add persistent scrollback buffers for all VGA consoles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 19:31:43 +0000
From:   Andrey Utkin <andrey_utkin@...tmail.com>
To:     Manuel Schölling <manuel.schoelling@....de>
Cc:     plagnioj@...osoft.com, tomi.valkeinen@...com, jslaby@...e.cz,
        gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] console: Add persistent scrollback buffers for
 all VGA consoles

Well done Manuel.

I'm not sure my emails with review of previous submission reached you, but in
them I meant to mention that there are some style nits which are easy to
eliminate.

checkpatch --strict is happy on patch 1/2, but on 2/2 there are few points. If
you ever have a reason to submit v7, please make sure to pick these points,
too. Except for the last one, which seems reasonable case to violate the rule
in my personal opinion.

 $ ./scripts/checkpatch.pl --strict ~/console2.patch 
CHECK: Please use a blank line after function/struct/union/enum declarations
#155: FILE: drivers/video/console/vgacon.c:175:
+};
+static struct vgacon_scrollback_info *vgacon_scrollback_cur;

CHECK: spaces preferred around that '/' (ctx:VxV)
#185: FILE: drivers/video/console/vgacon.c:196:
+	int rows = size/pitch;
 	               ^

CHECK: Alignment should match open parenthesis
#189: FILE: drivers/video/console/vgacon.c:200:
+	data = kmalloc_array(CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, 1024,
+		GFP_NOWAIT);

CHECK: braces {} should be used on all arms of this statement
#206: FILE: drivers/video/console/vgacon.c:217:
+	if (!vgacon_scrollbacks[vc_num].data)
[...]
+	else {
[...]

CHECK: Logical continuations should be on the previous line
#234: FILE: drivers/video/console/vgacon.c:241:
+	if (!vgacon_scrollback_cur->data || !vgacon_scrollback_cur->size
+	    || c->vc_num != fg_console)

WARNING: line over 80 characters
#259: FILE: drivers/video/console/vgacon.c:259:
+			vgacon_scrollback_cur->cnt = vgacon_scrollback_cur->rows;

total: 0 errors, 1 warnings, 5 checks, 258 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/home/j/console2.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



P. S. Manuel, please fix your git-send-email workflow or apply some
workaround (check locale settings and such). Again your References
header contains illegal symbol:

References: <201611210615.PPE1zXiO??ngguang.wu@...el.com>