linux-kernel - Re: [PATCH 2/3] iio: st_accel: Support sensor i2c probe using acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Nov 2016 15:26:51 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Shrirang Bagul <shrirang.bagul@...onical.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Denis CIOCCA <denis.ciocca@...com>,
        Tiberiu Breana <tiberiu.a.breana@...el.com>,
        Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        Gregor Boirie <gregor.boirie@...rot.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] iio: st_accel: Support sensor i2c probe using acpi

On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
<shrirang.bagul@...onical.com> wrote:

> Add support to probe st_accel sensors on i2c bus using ACPI. Compatible
> strings are not avaialable on ACPI based systems.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@...onical.com>
(...)

> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id st_accel_acpi_match[] = {
> +       {"SMO8A90", LNG2DM},
> +       { },
> +};

Why is ACPI only supporting one out of 14 devices?

Surely there are some out-of-tree ACPI platforms using one
or more of the others?

Apart from that it looks nice.

Yours,
Linus Walleij