linux-kernel - Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2016 09:30:07 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Robin van der Gracht <robin@...tonic.nl>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

On Friday, November 25, 2016 8:50:04 AM CET Robin van der Gracht wrote:
> 
> Thanks for reporting this. You are right about the missing helper.
> However, the fb_ops struct uses several helpers which are all missing.
> 
> static struct fb_ops ht16k33_fb_ops = {
>         .owner = THIS_MODULE,
>         .fb_read = fb_sys_read,
>         .fb_write = fb_sys_write,
>         .fb_fillrect = sys_fillrect,
>         .fb_copyarea = sys_copyarea,
>         .fb_imageblit = sys_imageblit,
>         .fb_mmap = ht16k33_mmap,
> };
> 
> HT16K33 should also select:
> FB_CFB_FILLRECT
> FB_CFB_COPYAREA
> FB_CFB_IMAGEBLIT
> 

Ah right. I had not run into those so far during randconfig
testing, probably because there is usually at least one other
framebuffer enabled that selects them.

Can you submit a patch to add all those?

	Arnd