linux-kernel - Re: [PATCH 01/10] power: supply: axp20x_usb_power: use of_device_id data field instead of device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2016 18:52:31 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     kbuild-all@...org, sre@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, wens@...e.org, linux@...linux.org.uk,
        maxime.ripard@...e-electrons.com, lee.jones@...aro.org,
        Quentin Schulz <quentin.schulz@...e-electrons.com>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH 01/10] power: supply: axp20x_usb_power: use of_device_id
 data field instead of device_is_compatible

Hi Quentin,

[auto build test WARNING on robh/for-next]
[also build test WARNING on v4.9-rc6 next-20161124]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Quentin-Schulz/add-support-for-VBUS-max-current-and-min-voltage-limits-AXP20X-and-AXP22X-PMICs/20161125-172224
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-s5-11251757 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe':
>> drivers/power/supply/axp20x_usb_power.c:233:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     power->axp20x_id = (int)of_id->data;
                        ^

vim +233 drivers/power/supply/axp20x_usb_power.c

   217		if (!of_device_is_available(pdev->dev.of_node))
   218			return -ENODEV;
   219	
   220		of_id = of_match_device(axp20x_usb_power_match, &pdev->dev);
   221		if (!of_id)
   222			return -ENODEV;
   223	
   224		if (!axp20x) {
   225			dev_err(&pdev->dev, "Parent drvdata not set\n");
   226			return -EINVAL;
   227		}
   228	
   229		power = devm_kzalloc(&pdev->dev, sizeof(*power), GFP_KERNEL);
   230		if (!power)
   231			return -ENOMEM;
   232	
 > 233		power->axp20x_id = (int)of_id->data;
   234	
   235		power->np = pdev->dev.of_node;
   236		power->regmap = axp20x->regmap;
   237	
   238		if (power->axp20x_id == AXP202_ID) {
   239			/* Enable vbus valid checking */
   240			ret = regmap_update_bits(power->regmap, AXP20X_VBUS_MON,
   241						 AXP20X_VBUS_MON_VBUS_VALID,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (23302 bytes)