linux-kernel - Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Nov 2016 17:14:06 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Marek Vasut <marek.vasut@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>
Subject: Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP
 capability for DT platform

On Sun, 27 Nov 2016 03:06:06 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> The denali_dt.c was split out by Altera for the SOCFPGA port.  The
> Denali IP on SOCFPGA incorporates the hardware ECC fixup feature.
> Newer versions are very likely to support it.  So, it should be OK
> to set DENALI_CAPS_HW_ECC_FIXUP for all DT platforms.

Seems like a bad idea. What's the problem with setting this flag in the
data->caps definition of each revision?

> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/mtd/nand/denali_dt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 293ddb8..9dcd203 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -59,6 +59,8 @@ static int denali_dt_probe(struct platform_device *ofdev)
>  	if (data)
>  		denali->caps = data->caps;
>  
> +	denali->caps |= DENALI_CAPS_HW_ECC_FIXUP;
> +
>  	denali->platform = DT;
>  	denali->dev = &ofdev->dev;
>  	denali->irq = platform_get_irq(ofdev, 0);