linux-kernel - Re: [RFC][PATCH 2/5 v2] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2016 09:58:59 -0800
From:   John Stultz <john.stultz@...aro.org>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Archit Taneja <architt@...eaurora.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [RFC][PATCH 2/5 v2] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()

On Mon, Nov 28, 2016 at 10:50 PM, Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
> Hi John,
>
> Thank you for the patch.
>
> On Monday 28 Nov 2016 21:04:41 John Stultz wrote:
>> In chasing down a previous issue with EDID probing from calling
>> drm_helper_hpd_irq_event() from irq context, Laurent noticed
>> that the DRM documentation suggests that
>> drm_kms_helper_hotplug_event() should be used instead.
>>
>> Thus this patch replaces drm_helper_hpd_irq_event() with
>> drm_kms_helper_hotplug_event().
>>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Archit Taneja <architt@...eaurora.org>
>> Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
>> Cc: Lars-Peter Clausen <lars@...afoo.de>
>> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>> Cc: dri-devel@...ts.freedesktop.org
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>> ---
>>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b38e743..2caca0c
>> 100644
>> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> @@ -406,7 +406,7 @@ static void adv7511_irq_work(struct work_struct *work)
>>  {
>>       struct adv7511 *adv7511 = container_of(work, struct adv7511,
> irq_work);
>>
>> -     drm_helper_hpd_irq_event(adv7511->connector.dev);
>> +     drm_kms_helper_hotplug_event(adv7511->connector.dev);
>
> That's nice, but you must first update adv7511->connector.status (and as an
> optimization only call drm_kms_helper_hotplug_event() if the status has
> changed).

Apologies for not seeing that subtlety. Thanks for pointing it out,
I've updated my patch.

thanks
-john