linux-kernel - [PATCH v2] reset: ti_syscon: fix a ti_syscon_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2016 09:03:32 +0800
From:   Jiancheng Xue <xuejiancheng@...ilicon.com>
To:     <p.zabel@...gutronix.de>
CC:     <linux-kernel@...r.kernel.org>, <afd@...com>, <s-anna@...com>,
        <yanhaifeng@...ilicon.com>, <zhangfei.gao@...il.com>,
        <xuejiancheng@...ilicon.com>
Subject: [PATCH v2] reset: ti_syscon: fix a ti_syscon_reset_status issue

If STATUS_SET was not set, ti_syscon_reset_status would always return 0
no matter whether the status_bit was set or not.

Signed-off-by: Jiancheng Xue <xuejiancheng@...ilicon.com>
---
Change Log
v2:
- Refined this patch according to the suggestion from Andrew F. Davis.

 drivers/reset/reset-ti-syscon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index 47f0ffd..1799fd4 100644
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -154,8 +154,8 @@ static int ti_syscon_reset_status(struct reset_controller_dev *rcdev,
 	if (ret)
 		return ret;
 
-	return (reset_state & BIT(control->status_bit)) &&
-			(control->flags & STATUS_SET);
+	return !(reset_state & BIT(control->status_bit)) ==
+		!(control->flags & STATUS_SET);
 }
 
 static struct reset_control_ops ti_syscon_reset_ops = {
-- 
1.9.1