linux-kernel - Re: [PATCH v14] acpi, apei, arm64: APEI initial support for aarch64.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Dec 2016 19:53:47 +0800
From:   Fu Wei <fu.wei@...aro.org>
To:     Borislav Petkov <bp@...e.de>
Cc:     Tomasz Nowicki <tn@...ihalf.com>, Tony Luck <tony.luck@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        x86@...nel.org,
        Linaro ACPI Mailman List <linaro-acpi@...ts.linaro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v14] acpi, apei, arm64: APEI initial support for aarch64.

Hi Borislav,

On 1 December 2016 at 19:41, Borislav Petkov <bp@...e.de> wrote:
> On Wed, Aug 10, 2016 at 09:02:48PM +0800, fu.wei@...aro.org wrote:
>> From: Tomasz Nowicki <tomasz.nowicki@...aro.org>
>>
>> This patch provides APEI arch-specific bits for aarch64
>>
>> Meanwhile,
>> (1)move HEST type (ACPI_HEST_TYPE_IA32_CORRECTED_CHECK) checking to
>> a generic place.
>> (2)select HAVE_ACPI_APEI when EFI and ACPI is set on ARM64,
>> because arch_apei_get_mem_attribute is using efi_mem_attributes on ARM64.
>
> ...
>
>> @@ -110,8 +111,27 @@ static inline const char *acpi_get_enable_method(int cpu)
>>  }
>>
>>  #ifdef       CONFIG_ACPI_APEI
>> +/*
>> + * acpi_disable_cmcff is used in drivers/acpi/apei/hest.c for disabling
>> + * IA-32 Architecture Corrected Machine Check (CMC) Firmware-First mode by
>> + * boot parameter(acpi=nocmcff). But we don't have this IA-32 specific
>
> Make that
>
> "... with a kernel command line parameter "acpi=nocmcoff"."
>
> Please fix that up when applying.
>
> With that:
>
> Reviewed-by: Borislav Petkov <bp@...e.de>

Great thanks for your rapidly feedback :-)

will send v15 with that fix  immediately

>
> Thanks!
>
> --
> Regards/Gruss,
>     Boris.
>
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
> --



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat