linux-kernel - Re: [PATCH v2] mtd: maps: add missing iounmap() in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2016 18:32:50 -0800
From:   Brian Norris <computersforpeace@...il.com>
To:     Marek Vasut <marek.vasut@...il.com>
Cc:     Luis Henriques <henrix@...andro.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: maps: add missing iounmap() in error path

On Fri, Nov 25, 2016 at 03:18:09PM +0100, Marek Vasut wrote:
> On 11/24/2016 12:40 AM, Luis Henriques wrote:
> > This patch was triggered by the following Coccinelle error:
> > 
> > ./drivers/mtd/maps/sc520cdp.c:246:3-9: \
> > 	ERROR: missing iounmap; ioremap on line 242 \
> > 	and execution via conditional on line 244
> > 
> > Since do_map_probe() is also invoked in this loop, it is also necessary to
> > map_destroy() any initialised struct mtd_info.
> > 
> > Signed-off-by: Luis Henriques <henrix@...andro.org>
> > ---
> > Changes since v1:
> > * Changes according to Brian Norris review:
> >   - Ensure sc520cdp_map[0].virt is unmaped when needed
> >   - Use a for loop instead of an 'if (i)'
> >   - Prevent double-iounmap
> > * Added map_destroy() in the cleanup
> > 
> > drivers/mtd/maps/sc520cdp.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)

...

> Reviewed-by: Marek Vasut <marek.vasut@...il.com>

Applied to l2-mtd.git