linux-kernel - Re: [PATCH V5] leds: pca955x: Add ACPI support for pca955x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 02 Dec 2016 09:40:05 +0100
From:   Jacek Anaszewski <j.anaszewski@...sung.com>
To:     Tin Huynh <tnhuynh@....com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Richard Purdie <rpurdie@...ys.net>,
        Peter Rosin <peda@...ntia.se>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, Loc Ho <lho@....com>,
        Thang Nguyen <tqnguyen@....com>, Phong Vo <pvo@....com>,
        patches@....com
Subject: Re: [PATCH V5] leds: pca955x: Add ACPI support for pca955x

Hi Tin,

On 12/02/2016 05:39 AM, Tin Huynh wrote:
> This patch enables ACPI support for leds-pca955x driver.
>
> Signed-off-by: Tin Huynh <tnhuynh@....com>
> ---
>  drivers/leds/leds-pca955x.c |   24 ++++++++++++++++++++++--
>  1 files changed, 22 insertions(+), 2 deletions(-)
>
> Change from V4:
>  -Using client->name instead of id->name to avoid NULL pointer in ACPI.
>
> Change from V3:
>  -Drop ".id =" and ".driver_data =" from pca955x_acpi_ids initializers.
>
> Change from V2:
>  -Correct coding conventions.
>
> Change from V1:
>  -Remove CONFIG_ACPI.
>
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index 840401a..78a7ce8 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -40,6 +40,7 @@
>   *  bits the chip supports.
>   */
>
> +#include <linux/acpi.h>
>  #include <linux/module.h>
>  #include <linux/delay.h>
>  #include <linux/string.h>
> @@ -100,6 +101,15 @@ struct pca955x_chipdef {
>  };
>  MODULE_DEVICE_TABLE(i2c, pca955x_id);
>
> +static const struct acpi_device_id pca955x_acpi_ids[] = {
> +	{ "PCA9550",  pca9550 },
> +	{ "PCA9551",  pca9551 },
> +	{ "PCA9552",  pca9552 },
> +	{ "PCA9553",  pca9553 },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(acpi, pca955x_acpi_ids);
> +
>  struct pca955x {
>  	struct mutex lock;
>  	struct pca955x_led *leds;
> @@ -250,7 +260,16 @@ static int pca955x_probe(struct i2c_client *client,
>  	struct led_platform_data *pdata;
>  	int i, err;
>
> -	chip = &pca955x_chipdefs[id->driver_data];
> +	if (id) {
> +		chip = &pca955x_chipdefs[id->driver_data];
> +	} else {
> +		const struct acpi_device_id *acpi_id;
> +
> +		acpi_id = acpi_match_device(pca955x_acpi_ids, &client->dev);
> +		if (!acpi_id)
> +			return -ENODEV;
> +		chip = &pca955x_chipdefs[acpi_id->driver_data];
> +	}
>  	adapter = to_i2c_adapter(client->dev.parent);
>  	pdata = dev_get_platdata(&client->dev);
>
> @@ -264,7 +283,7 @@ static int pca955x_probe(struct i2c_client *client,
>
>  	dev_info(&client->dev, "leds-pca955x: Using %s %d-bit LED driver at "
>  			"slave address 0x%02x\n",
> -			id->name, chip->bits, client->addr);
> +			client->name, chip->bits, client->addr);
>
>  	if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
>  		return -EIO;
> @@ -358,6 +377,7 @@ static int pca955x_remove(struct i2c_client *client)
>  static struct i2c_driver pca955x_driver = {
>  	.driver = {
>  		.name	= "leds-pca955x",
> +		.acpi_match_table = ACPI_PTR(pca955x_acpi_ids),
>  	},
>  	.probe	= pca955x_probe,
>  	.remove	= pca955x_remove,
>

Thanks for the quick reaction. Replaced v4 with v5 on the for-next
branch.

-- 
Best regards,
Jacek Anaszewski