linux-kernel - Re: [PATCH] fuse: freezing abort when use wait_event_killable{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Dec 2016 00:16:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     cuilifei <cuilifei@...omi.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org, miklos@...redi.hu,
        cuilifei <cuilifei@...omi.com>
Subject: Re: [PATCH] fuse: freezing abort when use
 wait_event_killable{,_exclusive}().

Hi cuilifei,

[auto build test WARNING on fuse/for-next]
[also build test WARNING on v4.9-rc7 next-20161202]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/cuilifei/fuse-freezing-abort-when-use-wait_event_killable-_exclusive/20161202-234345
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
config: x86_64-randconfig-x013-201648 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/uapi/linux/fuse.h:121,
                    from fs/fuse/fuse_i.h:12,
                    from fs/fuse/dev.c:9:
   fs/fuse/dev.c: In function '__fuse_get_req':
   fs/fuse/dev.c:38:8: error: implicit declaration of function 'freezing' [-Werror=implicit-function-declaration]
      if (!freezing(current))     \
           ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> fs/fuse/dev.c:38:3: note: in expansion of macro 'if'
      if (!freezing(current))     \
      ^~
   fs/fuse/dev.c:176:10: note: in expansion of macro 'wait_fatal_freezable'
      intr = wait_fatal_freezable(fc->blocked_waitq,
             ^~~~~~~~~~~~~~~~~~~~
   fs/fuse/dev.c:40:11: error: implicit declaration of function 'try_to_freeze' [-Werror=implicit-function-declaration]
     } while (try_to_freeze());     \
              ^
   fs/fuse/dev.c:176:10: note: in expansion of macro 'wait_fatal_freezable'
      intr = wait_fatal_freezable(fc->blocked_waitq,
             ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/if +38 fs/fuse/dev.c

     3	  Copyright (C) 2001-2008  Miklos Szeredi <miklos@...redi.hu>
     4	
     5	  This program can be distributed under the terms of the GNU GPL.
     6	  See the file COPYING.
     7	*/
     8	
   > 9	#include "fuse_i.h"
    10	
    11	#include <linux/init.h>
    12	#include <linux/module.h>
    13	#include <linux/poll.h>
    14	#include <linux/uio.h>
    15	#include <linux/miscdevice.h>
    16	#include <linux/pagemap.h>
    17	#include <linux/file.h>
    18	#include <linux/slab.h>
    19	#include <linux/pipe_fs_i.h>
    20	#include <linux/swap.h>
    21	#include <linux/splice.h>
    22	
    23	MODULE_ALIAS_MISCDEV(FUSE_MINOR);
    24	MODULE_ALIAS("devname:fuse");
    25	
    26	#define wait_fatal_freezable(wq, condition, exclusive)			\
    27	({									\
    28		int __ret = 0;							\
    29		do {								\
    30			if (exclusive)						\
    31				__ret = wait_event_interruptible_exclusive(wq,	\
    32								condition);	\
    33			else							\
    34				__ret = wait_event_interruptible(wq,		\
    35								condition);	\
    36			if (!__ret || fatal_signal_pending(current))		\
    37				break;						\
  > 38			if (!freezing(current))					\
    39				continue;					\
    40		} while (try_to_freeze());					\
    41		__ret;								\

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (18547 bytes)