linux-kernel - Re: [PATCH] staging: greybus: Fix macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Dec 2016 16:17:37 +0530
From:   Chinmay V S <cvs268@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     elder@...nel.org, johan@...nel.org,
        "Bryan O'Donoghue" <pure.logic@...us-software.ie>,
        devel@...verdev.osuosl.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: greybus: Fix macro definition

On Sat, Dec 3, 2016 at 3:52 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote:
>> From: ChinmayVS <cvs268@...il.com>
>>
>> Macros with multiple statements should be enclosed in a do - while loop
>>
>> Signed-off-by: ChinmayVS <cvs268@...il.com>
>> ---
>>  drivers/staging/greybus/loopback.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
>> index 7882306..39f0a25 100644
>> --- a/drivers/staging/greybus/loopback.c
>> +++ b/drivers/staging/greybus/loopback.c
>> @@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev,               \
>>  static DEVICE_ATTR_RO(name##_avg)
>>
>>  #define gb_loopback_stats_attrs(field)                               \
>> +do {                                                         \
>>       gb_loopback_ro_stats_attr(field, min, u);               \
>>       gb_loopback_ro_stats_attr(field, max, u);               \
>> -     gb_loopback_ro_avg_attr(field)
>> +     gb_loopback_ro_avg_attr(field)                          \
>> +} while (0)
>>
>>  #define gb_loopback_attr(field, type)                                        \
>>  static ssize_t field##_show(struct device *dev,                              \
>
> Always build test your changes so you don't get a grumpy maintainer
> yelling at you for not test-building your patches...
>

Thanks. My bad.
Now that i tried and saw it doesn't even build, i see my mistake.
gb_loopback_stats_attrs() is used to define functions from a template.
The macro is not in any function by itself already.

Back to running checkpatch and finding other ERRORs to cleanup in staging.
(will remember to +V before pushing to the mailing list.)