linux-kernel - Re: [PATCH v1 2/2] crypto: mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2016 10:45:00 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Ryder Lee <ryder.lee@...iatek.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Sean Wang <sean.wang@...iatek.com>,
        Roy Luo <cheng-hao.luo@...iatek.com>
Subject: Re: [PATCH v1 2/2] crypto: mediatek - add DT bindings documentation



On 08/12/16 10:19, Ryder Lee wrote:
> Hello,
>
> On Mon, 2016-12-05 at 11:18 +0100, Matthias Brugger wrote:
>>
>> On 05/12/16 08:01, Ryder Lee wrote:
>>> Add DT bindings documentation for the crypto driver
>>>
>>> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
>>> ---
>>>  .../devicetree/bindings/crypto/mediatek-crypto.txt | 32 ++++++++++++++++++++++
>>>  1 file changed, 32 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
>>> new file mode 100644
>>> index 0000000..8b1db08
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
>>> @@ -0,0 +1,32 @@
>>> +MediaTek cryptographic accelerators
>>> +
>>> +Required properties:
>>> +- compatible: Should be "mediatek,mt7623-crypto"
>>
>> Do you know how big the difference is between the crypto engine for
>> mt7623/mt2701/mt8521p in comparison, let's say mt8173 or mt6797?
>> Do this SoCs have a crypot engine? If so and they are quite similar, we
>> might think of adding a mtk-crypto binding and add soc specific bindings.
>
> This engine is just available in mt7623/mt2701/mt8521p series SoCs and
> they have no difference.
>
> But there are still other crypto IPs in MTK, i think maybe we could use
> "mediatek,{IP name}-crypto” to distinguish them ?
>

Sounds good, thanks for the clarification.

Matthias


>> Regards,
>> Matthias
>>
>>> +- reg: Address and length of the register set for the device
>>> +- interrupts: Should contain the five crypto engines interrupts in numeric
>>> +	order. These are global system and four descriptor rings.
>>> +- clocks: the clock used by the core
>>> +- clock-names: the names of the clock listed in the clocks property. These are
>>> +	"ethif", "cryp"
>>> +- power-domains: Must contain a reference to the PM domain.
>>> +
>>> +
>>> +Optional properties:
>>> +- interrupt-parent: Should be the phandle for the interrupt controller
>>> +  that services interrupts for this device
>>> +
>>> +
>>> +Example:
>>> +	crypto: crypto@...40000 {
>>> +		compatible = "mediatek,mt7623-crypto";
>>> +		reg = <0 0x1b240000 0 0x20000>;
>>> +		interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>,
>>> +			     <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>,
>>> +			     <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
>>> +			     <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
>>> +			     <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
>>> +		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
>>> +			 <&ethsys CLK_ETHSYS_CRYPTO>;
>>> +		clock-names = "ethif","cryp";
>>> +		power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
>>> +	};
>>>
>
>