linux-kernel - Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2016 18:00:33 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:     Patrick Scheuring <patrick.scheuring.dev@...il.com>,
        Aurélien Francillon <aurelien@...ncillon.net>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: i8042-x86ia64io.h - Comment else/endif of
 CONFIG_PNP

On Fri, Dec 09, 2016 at 09:55:09PM -0200, Marcos Paulo de Souza wrote:
> As this define check if huge, this makes easier to read the code.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>

Applied, thank you.

> ---
>  While reviewing patches from Dmitry about presence of 8042, it makes it
>  much easier to understand the ifdefs...
> 
>  drivers/input/serio/i8042-x86ia64io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 073246c..ddd3132 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -1131,10 +1131,10 @@ static int __init i8042_pnp_init(void)
>  	return 0;
>  }
>  
> -#else
> +#else  /* !CONFIG_PNP */
>  static inline int i8042_pnp_init(void) { return 0; }
>  static inline void i8042_pnp_exit(void) { }
> -#endif
> +#endif /* CONFIG_PNP */
>  
>  static int __init i8042_platform_init(void)
>  {
> -- 
> 2.9.3
> 

-- 
Dmitry