linux-kernel - Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 10:32:14 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Borislav Petkov <bp@...e.de>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de, hpa@...or.com,
        mingo@...hat.com, x86@...nel.org, keescook@...omium.org,
        yinghai@...nel.org, thgarnie@...gle.com, kuleshovmail@...il.com,
        luto@...nel.org, mcgrof@...nel.org, anderson@...hat.com,
        dyoung@...hat.com, xlpang@...hat.com
Subject: Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size
 at runtime

On 12/11/16 at 01:06pm, Borislav Petkov wrote:
> On Sun, Dec 11, 2016 at 06:58:29PM +0800, Baoquan He wrote:
> > For arguing and defending myself, I couldn't be very objective.
> 
> Yeah, it is mind-boggling the amount of bullshit you would come up with
> instead of simply saying, "no, I don't have a good reason and use case
> for my patch". It made me laugh, FWIW. Especially the bit about people
> getting naked - I had to go check we're still talking about the same
> thing.

Yes, I can't agree more, that use case is totally of bullshit. At the
very beginning, we all know that this patch is trying to fix the
inconsistency between kaslr codes not compiled in and code compiled in
but with "nokaslr" specified. In short, this patch is fixing an
inconsistency, no bug is reported yet. Here the inconsistency is the
reason for this patch. I think it has been made very clearly now. This
also has been pointed out by Kees when he offered his "Acked-by". I
welcome and treat all comments seriously, no other choices are given
to me.

If at the start, you said straightforwardly like:

"No bug, no fix!"

"A little inconsistency makes the world more exciting, it can make me
high."

or
"We can leave with it until a bug is reported, remaining 1G is no harm."

I can accept it totally and mute. But I didn't hear them. As an expert of
x86 arch and authority, you honor me to step in and give comments, I
have to reply with respect.

I am very glad to see you said you laughed at something, whatever it is
for, at least it means thing is not screwed up thoroughly, laughter is
always good.

Thanks
Baoquan