linux-kernel - Re: [PATCH 1/1] Fixed to codestyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 07:49:18 -0600
From:   Eric Sandeen <sandeen@...deen.net>
To:     Ozgur Karatas <okaratas@...ber.fsf.org>, david@...morbit.com
Cc:     linux-xfs@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 4:53 AM, Ozgur Karatas wrote:
> 
> Hello,
> 
> I have error to use uuid and I think the functions should be used when -i'm eye-catching- "(* uuid)".
> I tested it.
> 
> Regards,
> 
> Signed-off-by: Ozgur Karatas <okaratas@...ber.fsf.org>

NAK

This doesn't fix code style at all; there is no need and no
precedence for i.e. (*uuid) in function arguments in the xfs code,
and you have broken indentation in the loop within the function.

Thanks,
-Eric

> ---
> diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c
> index b83f76b..cd8bc8e 100644
> --- a/fs/xfs/uuid.c
> +++ b/fs/xfs/uuid.c
> @@ -33,7 +33,7 @@ typedef struct {
>   * it just something that's needed for user-level file handles.
>   */
>  void
> -uuid_getnodeuniq(uuid_t *uuid, int fsid [2])
> +uuid_getnodeuniq(uuid_t (*uuid), int fsid [2])
>  {
>  	xfs_uu_t *uup = (xfs_uu_t *)uuid;
>  
> @@ -51,8 +51,8 @@ uuid_is_nil(uuid_t *uuid)
>  	if (uuid == NULL)
>  		return 0;
>  	/* implied check of version number here... */
> -	for (i = 0; i < sizeof *uuid; i++)
> -		if (*cp++) return 0;	/* not nil */
> +	for (i = 0; i < sizeof (*uuid); i++) 
> +	if (*cp++) return 0;	/* not nil */
>  	return 1;	/* is nil */
>  }
>