linux-kernel - Re: [PATCH] clk/axs10x: Clear init field in driver probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 11:03:32 -0800
From:   Michael Turquette <mturquette@...libre.com>
To:     Jose Abreu <Jose.Abreu@...opsys.com>, linux-clk@...r.kernel.org
Cc:     "Jose Abreu" <Jose.Abreu@...opsys.com>,
        "Carlos Palminha" <CARLOS.PALMINHA@...opsys.com>,
        "Stephen Boyd" <sboyd@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk/axs10x: Clear init field in driver probe

Quoting Jose Abreu (2016-12-12 03:08:55)
> Init field must be cleared in driver probe as this structure is not dinamically allocated. If not, wrong flags can be passed to core.
> 
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>

Applied to clk-next. You can find this patch merged after v4.10-rc1 is
released in a couple of weeks.

Regards,
Mike

> Cc: Carlos Palminha <palminha@...opsys.com>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: linux-clk@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/clk/axs10x/i2s_pll_clock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/axs10x/i2s_pll_clock.c b/drivers/clk/axs10x/i2s_pll_clock.c
> index 411310d..02d3bcd 100644
> --- a/drivers/clk/axs10x/i2s_pll_clock.c
> +++ b/drivers/clk/axs10x/i2s_pll_clock.c
> @@ -182,6 +182,7 @@ static int i2s_pll_clk_probe(struct platform_device *pdev)
>         if (IS_ERR(pll_clk->base))
>                 return PTR_ERR(pll_clk->base);
>  
> +       memset(&init, 0, sizeof(init));
>         clk_name = node->name;
>         init.name = clk_name;
>         init.ops = &i2s_pll_ops;
> -- 
> 1.9.1
> 
>