linux-kernel - Re: [PATCH] Documentation: ti-syscon-reset: fix header path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 20:52:26 +0100
From:   Yegor Yefremov <yegorslists@...glemail.com>
To:     Rob Herring <robh@...nel.org>
Cc:     kernel list <linux-kernel@...r.kernel.org>, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, mark.rutland@....com
Subject: Re: [PATCH] Documentation: ti-syscon-reset: fix header path

On Mon, Dec 12, 2016 at 7:40 PM, Rob Herring <robh@...nel.org> wrote:
> On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorslists@...glemail.com wrote:
>> From: Yegor Yefremov <yegorslists@...glemail.com>
>>
>> 'include' was missing from path.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@...glemail.com>
>> ---
>>  Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> index 164c7f3..5b20e20 100644
>> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
>> @@ -44,7 +44,7 @@ Required properties:
>>                                     reset status register
>>                           Cell #7 : Flags used to control reset behavior,
>>                                     availible flags defined in the DT include
>> -                                   file <dt-bindings/reset/ti-syscon.h>
>> +                                   file <include/dt-bindings/reset/ti-syscon.h>
>
> There's pretty much equal mixture of include or not. Not really much
> point in fixing 1 instance if there's no clear correct way. Given it is
> written with <...>, that matches how you write the include statement.

OK I see the point of omitting include now. I was looking at this from
VIM point of view. I cannot automatically jump to the file via 'gf'.

Yegor