linux-kernel - Re: [PATCH] ACPI: small formatting fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 23:22:16 +0100
From:   Pavel Machek <pavel@....cz>
To:     Joe Perches <joe@...ches.com>
Cc:     Nick Desaulniers <nick.desaulniers@...il.com>, rjw@...ysocki.net,
        len.brown@...el.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: small formatting fixes

On Mon 2016-12-12 10:39:15, Joe Perches wrote:
> On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote:
> > A quick cleanup that passes scripts/checkpatch.pl -f <file>.
> 
> You might use the --strict option for acpi files.

Please... don't encourage people more, we have enough cleanup patches
as is.

> > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> []
> > @@ -103,9 +103,8 @@ static long acpi_processor_ffh_cstate_probe_cpu(void *_cx)
> >  
> >         if (!mwait_supported[cstate_type]) {
> >                 mwait_supported[cstate_type] = 1;
> > -               printk(KERN_DEBUG
> > -                       "Monitor-Mwait will be used to enter C-%d "
> > -                       "state\n", cx->type);
> > +               pr_debug("Monitor-Mwait will be used to enter C-%d state\n",
> > +                               cx->type);
> 
> It's generally better not to convert
> these printk(KERN_DEBUG uses.
> 
> There are behavior differences between
> 	printk(KERN_DEBUG ...);
> and
> 	pr_debug(...);
> 
> The first will always be emitted as long
> as the console level is appropriate.
> 
> The second depends on a #define DEBUG
> before it gets emitted or a kernel
> with CONFIG_DYNAMIC_DEBUG enabled and
> this entry specifically enabled in the
> control file.

Hmm. Perhaps pr_debug should be called pr_c_debug() or something? This
is rather nice trap.

Anyway with that fixed,

Acked-by: Pavel Machek <pavel@....cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)