linux-kernel - Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2016 03:54:59 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Michał Kępień <kernel@...pniu.pl>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <j.anaszewski@...sung.com>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Darren Hart <dvhart@...radead.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Louis Davis <Louis_Davis@...l.com>,
        Jim Dailey <Jim_Dailey@...l.com>,
        Alex Hung <alex.hung@...onical.com>,
        Hui Wang <hui.wang@...onical.com>, linux-leds@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()

On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
>> All calls to dell_app_wmi_led_set() have been replaced with direct
>> calls to dell_micmute_led_set(), so the former can be safely removed
>> along with its related enum.
>>
>> Signed-off-by: Michał Kępień <kernel@...pniu.pl>
>
> I would suggest to squash patches 2,3,4 into one. But I let decision to
> alsa & led maintainers.

I don't like the part where we are exporting something for just one
moment. So, +1 to squashed version.

>
> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup
>
> Reviewed-by: Pali Rohár <pali.rohar@...il.com>
>
> --
> Pali Rohár
> pali.rohar@...il.com



-- 
With Best Regards,
Andy Shevchenko