linux-kernel - Re: [PATCH] drivers: staging: comedi: fix function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2016 11:44:54 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Piotr Gregor <piotrgregor@...ncme.org>
Cc:     hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: comedi: fix function prototypes

On 14/12/16 13:42, Piotr Gregor wrote:
> Add names of parameters to function prototypes in comedi PCI.
> Checkpatch reports now no errors.
>
> Signed-off-by: Piotr Gregor <piotrgregor@...ncme.org>
> ---
>  drivers/staging/comedi/comedi_pci.h | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 4005cc9..7dfd892 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -34,18 +34,20 @@
>  #define PCI_VENDOR_ID_RTD		0x1435
>  #define PCI_VENDOR_ID_HUMUSOFT		0x186c
>
> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
> +struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);
>
> -int comedi_pci_enable(struct comedi_device *);
> -void comedi_pci_disable(struct comedi_device *);
> -void comedi_pci_detach(struct comedi_device *);
> +int comedi_pci_enable(struct comedi_device *dev);
> +void comedi_pci_disable(struct comedi_device *dev);
> +void comedi_pci_detach(struct comedi_device *dev);
>
> -int comedi_pci_auto_config(struct pci_dev *, struct comedi_driver *,
> +int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
>  			   unsigned long context);
> -void comedi_pci_auto_unconfig(struct pci_dev *);
> +void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
>
> -int comedi_pci_driver_register(struct comedi_driver *, struct pci_driver *);
> -void comedi_pci_driver_unregister(struct comedi_driver *, struct pci_driver *);
> +int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
> +			       struct pci_driver *pci_driver);
> +void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
> +				  struct pci_driver *pci_driver);
>
>  /**
>   * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
>

Looks good, thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-