lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Dec 2016 17:38:34 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: Tabrez khan <khan.tabrez21@...il.com> Cc: andreas.dilger@...el.com, jsimmons@...radead.org, lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging : osc : Remove braces from single-line body On Thu, Dec 15, 2016 at 07:03:52AM +0530, Tabrez khan wrote: > Remove unnecessary braces {} for single if statement block. > This warning is found using checkpatch.pl. > > Signed-off-by: Tabrez khan <khan.tabrez21@...il.com> > --- > drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c > index 4bbe219..5ded31a 100644 > --- a/drivers/staging/lustre/lustre/osc/osc_cache.c > +++ b/drivers/staging/lustre/lustre/osc/osc_cache.c > @@ -1420,10 +1420,8 @@ static void osc_release_write_grant(struct client_obd *cli, > struct brw_page *pga) > { > assert_spin_locked(&cli->cl_loi_list_lock); > - if (!(pga->flag & OBD_BRW_FROM_GRANT)) { > + if (!(pga->flag & OBD_BRW_FROM_GRANT)) > return; > - } > - Why did you also delete the blank line?
Powered by blists - more mailing lists