linux-kernel - Re: [PATCH] acpi: Fix format string type mistakes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Dec 2016 15:04:22 -0800
From:   Kees Cook <keescook@...omium.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Robert Moore <robert.moore@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lv Zheng <lv.zheng@...el.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Emese Revfy <re.emese@...il.com>,
        "devel@...ica.org" <devel@...ica.org>
Subject: Re: [PATCH] acpi: Fix format string type mistakes

On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keescook@...omium.org> wrote:
>> From: Emese Revfy <re.emese@...il.com>
>>
>> This adds the missing __printf attribute which allows compile time
>> format string checking (and will be used by the coming initify gcc
>> plugin). Additionally, this fixes the warnings exposed by the attribute.
>>
>> Signed-off-by: Emese Revfy <re.emese@...il.com>
>> [kees: split scsi/acpi, merged attr and fix, new commit messages]
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> This modifies code that we get from an external projiect (ACPICA) and
> the bugs should be fixed in there in the first place.

Who should get CCed?

> Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea.

Why not? This is going to be needed by the initify plugin to do
correct detection of what's being passed around to functions...

-Kees

-- 
Kees Cook
Nexus Security