linux-kernel - Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Dec 2016 19:24:46 +0000
From:   Afonso Bordado <afonsobordado@....co>
To:     Joe Perches <joe@...ches.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

> Instead of merely converting Hungarian CamelCase to lowercase
> with underscores where word transitions occurred, try reading
> the code and making sense of what it does to perhaps find a
> better variable name instead.  Maybe eliminate the variable
> altogether.
>
> iWordLength could be reads or numreads

Ok!

> btw: what happens if length is not a multiple of sizeof(u32)?

Reading over the code (something I should have done the first time)
it seems that it rounds down, not doing the full transfer, and EP0_out_OverBytes
handles the remaining transfer.

Since EP0_out_OverBytes is only called once and for this purpose would it be
perferable to do that on EP0_out_PIO?

> nret is more commonly ret
> p_buf is also not common linux naming, buf is more common.

Ok!