linux-kernel - Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Dec 2016 11:30:05 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     devendra sharma <devendra.sharma9091@...il.com>
Cc:     abbotti@....co.uk, hsweeten@...ionengravers.com,
        ansonjacob.aj@...il.com, amitoj1606@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings

On Sun, Dec 18, 2016 at 03:43:15PM +0530, devendra sharma wrote:
> Fixed check patch warnings about multiple line dereferencing

What does that mean?

> 
> Signed-off-by: Devendra Sharma <devendra.sharma9091@...il.com>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index cb9c269..946c580 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct comedi_device *dev)
>  		if (ao_cmd_is_supported(board)) {
>  			devpriv->ao_buffer[i] =
>  				dma_alloc_coherent(&pcidev->dev,
> -						   DMA_BUFFER_SIZE,
> -						   &devpriv->
> -						   ao_buffer_bus_addr[i],
> -						   GFP_KERNEL);
> +				   DMA_BUFFER_SIZE,
> +				   &devpriv->ao_buffer_bus_addr[i],
> +				   GFP_KERNEL);
>  			if (!devpriv->ao_buffer[i])
>  				return -ENOMEM;
>  		}
> @@ -2476,18 +2475,15 @@ static int setup_channel_queue(struct comedi_device *dev,
>  			for (i = 0; i < cmd->chanlist_len; i++) {
>  				bits = 0;
>  				/* set channel */
> -				bits |= adc_chan_bits(CR_CHAN(cmd->
> -							      chanlist[i]));
> +				bits |= adc_chan_bits(
> +				CR_CHAN(cmd->chanlist[i]));

That doesn't look better to me, does it to you?

checkpatch is a guide, don't let it make you write code that isn't easy
to understand.

thanks,

greg k-h