lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Dec 2016 14:37:46 +0100 From: Martin Blumenstingl <martin.blumenstingl@...glemail.com> To: Florian Fainelli <f.fainelli@...il.com>, jbrunet@...libre.com Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, devicetree@...r.kernel.org, carlo@...one.org, khilman@...libre.com, peppe.cavallaro@...com, alexandre.torgue@...com, neolynx@...il.com, andrew@...n.ch, narmstrong@...libre.com, linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Hi Florian, Hi Jerome, On Wed, Nov 30, 2016 at 2:15 AM, Florian Fainelli <f.fainelli@...il.com> wrote: > On 11/29/2016 05:13 PM, David Miller wrote: >> From: Florian Fainelli <f.fainelli@...il.com> >> Date: Tue, 29 Nov 2016 16:43:20 -0800 >> >>> On 11/29/2016 04:38 PM, David Miller wrote: >>>> From: Jerome Brunet <jbrunet@...libre.com> >>>> Date: Mon, 28 Nov 2016 10:46:45 +0100 >>>> >>>>> This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). >>>>> The platform seems to enter LPI on the Rx path too often while performing >>>>> relatively high TX transfer. This eventually break the link (both Tx and >>>>> Rx), and require to bring the interface down and up again to get the Rx >>>>> path working again. >>>>> >>>>> The root cause of this issue is not fully understood yet but disabling EEE >>>>> advertisement on the PHY prevent this feature to be negotiated. >>>>> With this change, the link is stable and reliable, with the expected >>>>> throughput performance. >>>>> >>>>> The patchset adds options in the generic phy driver to disable EEE >>>>> advertisement, through device tree. The way it is done is very similar >>>>> to the handling of the max-speed property. >>>> >>>> Patches 1-3 applied to net-next, thanks. >>> >>> Meh, there was a v4 submitted shortly after, and I objected to the whole >>> idea of using that kind of Device Tree properties to disable EEE, we can >>> send reverts though.. >> >> Sorry, I lost this in all the discussion, I can revert. > > Yeah, I can understand why, these freaking PHYs tend to generate a lot > of noise and discussion... > >> >> Just send me a revert of the entire merge commit >> a152c91889556df17ca6d8ea134fb2cb4ac9f893 with a short >> description of why and I'll apply it. > > OK, I will talk with Jerome first to make sure that we are in agreement > with the solution to deploy to fix the OdroidC2 problem first. simply because I'm curious: what was the outcome of your discussion? can we stay with the current solution or are any changes required? Regards, Martin
Powered by blists - more mailing lists