linux-kernel - Re: [PATCH 1/1] x86/platform/intel/quark: add printf attribute to imr_self_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b12e4ca-4709-b3a3-6479-e395c48a38c3@nexus-software.ie>
Date:   Tue, 20 Dec 2016 00:28:23 +0000
From:   Bryan O'Donoghue <pure.logic@...us-software.ie>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] x86/platform/intel/quark: add printf attribute to
 imr_self_test_result()



On 19/12/16 13:21, Nicolas Iooss wrote:
> __printf attributes help detecting issues in printf format strings at
> compile time.
>
> Even though imr_selftest.c is only compiled with
> CONFIG_DEBUG_IMR_SELFTEST, gcc complains about a missing format
> attribute when compiling allmodconfig with -Wmissing-format-attribute.
> Silent this warning by adding the attribute.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>
> ---
>  arch/x86/platform/intel-quark/imr_selftest.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c
> index f5bad40936ac..b8f562049cad 100644
> --- a/arch/x86/platform/intel-quark/imr_selftest.c
> +++ b/arch/x86/platform/intel-quark/imr_selftest.c
> @@ -25,7 +25,8 @@
>   * @fmt:	format string.
>   * ...		variadic argument list.
>   */
> -static void __init imr_self_test_result(int res, const char *fmt, ...)
> +static __printf(2, 3)
> +void __init imr_self_test_result(int res, const char *fmt, ...)
>  {
>  	va_list vlist;
>
>

since I wrote this code.

Acked-by: Bryan O'Donoghue <pure.logic@...us-software.ie>

cheers

---
bod