linux-kernel - Re: [PATCH] kernel: sys: fix out of place EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Dec 2016 07:49:50 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Thomas Casey <tqcasey@...il.com>
Cc:     akpm@...ux-foundation.org, john.stultz@...aro.org,
        tglx@...utronix.de, gorcunov@...nvz.org, nicolas.pitre@...aro.org,
        skinsbursky@...tuozzo.com, mguzik@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call

On Tue 20-12-16 14:39:19, Thomas Casey wrote:
> Fixes two instances of EXPORT_SYMBOL not being called immediately after
> the initialization of its argument

What does this fix actually?

> Signed-off-by: Thomas Casey <tqcasey@...il.com>
> ---
>  kernel/sys.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 9758892a2d09..8afd3e341f9b 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -110,9 +110,8 @@
>   */
>  
>  int overflowuid = DEFAULT_OVERFLOWUID;
> -int overflowgid = DEFAULT_OVERFLOWGID;
> -
>  EXPORT_SYMBOL(overflowuid);
> +int overflowgid = DEFAULT_OVERFLOWGID;
>  EXPORT_SYMBOL(overflowgid);
>  
>  /*
> @@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
>   */
>  
>  int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
> -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> -
>  EXPORT_SYMBOL(fs_overflowuid);
> +int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
>  EXPORT_SYMBOL(fs_overflowgid);
>  
>  /*
> -- 
> 2.11.0
> 

-- 
Michal Hocko
SUSE Labs