linux-kernel - [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL error from pcim_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Dec 2016 17:09:19 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     jarkko.nikula@...ux.intel.com, wsa@...-dreams.de
Cc:     andriy.shevchenko@...ux.intel.com, mika.westerberg@...ux.intel.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [v1] i2c: busses: i2c-designware-pcidrv:- Handle return NULL error from pcim_iomap_table

Here, If pcim_iomap_table will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/i2c/busses/i2c-designware-pcidrv.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index d6423cf..6a1907d 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -235,6 +235,10 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
 	dev->controller = controller;
 	dev->get_clk_rate_khz = i2c_dw_get_clk_rate_khz;
 	dev->base = pcim_iomap_table(pdev)[0];
+	if (!dev->base) {
+		dev_err(&pdev->dev, "I/O map table allocation failed\n");
+		return -ENOMEM;
+	}
 	dev->dev = &pdev->dev;
 	dev->irq = pdev->irq;
 
-- 
1.7.9.5