lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Dec 2016 21:38:08 +0100 From: Peter Rosin <peda@...ntia.se> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: linux-kernel@...r.kernel.org, Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org, Wenyou Yang <wenyou.yang@...el.com> Subject: Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: >> The gpiod_get* function family does not want the -gpio suffix. >> Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. >> The descriptor based APIs handle active high/low automatically. >> The vbus-gpios are output, request enable while getting the gpio. >> Don't try to get any vbus-gpios for ports outside num-ports. >> >> WTF? Big sigh. >> >> Fixes: 054d4b7b577d ("usb: ohci-at91: Use descriptor-based gpio APIs") >> Signed-off-by: Peter Rosin <peda@...ntia.se> >> --- >> >> Hi! >> >> Resending this, since the only response I've got is that the merge >> window is open and that this patch has been put on hold due to that. >> But I think this regression (which happend between v4.9 and current >> master) should be fixed before the merge window closes. > > I don't merge patches before -rc1 comes out, sorry, people should have > tested linux-next better :) Neat, shift the blame for the shit patch over to the messenger :) > I'll catch up the first week of January, relax. As we all know, unrelated regressions are painful when trying to locate other problems. It's seems silly to have a few extra for no good reason. *I* know about this one, it's those you don't know about that are worst. Cheers, peda
Powered by blists - more mailing lists