linux-kernel - Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Dec 2016 15:52:48 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Jonathan Cameron <jic23@...23.retrosnub.co.uk>,
        Sebastian Reichel <sre@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        Michael Welling <mwelling@...e.org>,
        Mika Penttilä <mika.penttila@...tfour.com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Igor Grinberg <grinberg@...pulab.co.il>,
        "Andrew F. Davis" <afd@...com>, Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Alexander Stein <alexander.stein@...tec-electronic.com>,
        Eric Engestrom <eric@...estrom.ch>,
        Hans de Goede <hdegoede@...hat.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Petr Cvek <petr.cvek@....cz>, linux-input@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-omap <linux-omap@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>, linux-iio@...r.kernel.org,
        kernel@...a-handheld.com,
        "Yann E. MORIN" <yann.morin.1998@...e.fr>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v8 3/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature

Hi Dmitry,

> Am 27.12.2016 um 22:54 schrieb Dmitry Torokhov <dmitry.torokhov@...il.com>:
> 
> On Mon, Dec 12, 2016 at 10:21:25PM +0100, H. Nikolaus Schaller wrote:
>> Hi,
>> 
>> 
>>> Am 27.11.2016 um 16:47 schrieb H. Nikolaus Schaller <hns@...delico.com>:
>>> 
>>> Hi Jonathan,
>>> 
>>>> Am 27.11.2016 um 12:02 schrieb Jonathan Cameron <jic23@...nel.org>:
>>>> 
>>>> On 24/11/16 18:05, H. Nikolaus Schaller wrote:
>>>>> 
>>>>>> Am 24.11.2016 um 18:38 schrieb Jonathan Cameron <jic23@...23.retrosnub.co.uk>:
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> On 22 November 2016 14:02:30 GMT+00:00, "H. Nikolaus Schaller" <hns@...delico.com> wrote:
>> 
>>> 
>>>> - hence cc'd Yann and the Kbuild list
>>>> to see if they can offer some advices.
>> 
>> no response / advice so far.
> 
> Since you are saying that IIO stuff is optional, add it to Kconfig
> explicitly:
> 
> config "TOUCHSCREEN_TSC2007_IIO"
> 	bool "IIO interface for external ADC input and temperature"
> 	depends on TOUCHSCREEN_TSC2007
> 	depends on IIO=y || IIO=TOUCHSCREEN_TSC2007
> 	help
> 	  ...
> 
> and use this symbols in makefile:
> 
> and in Makefile:
> 
> obj-$(CONFIG_TOUCHSCREEN_TSC2007) += tsc2007.o
> tsc2007-y := tsc2007-core.o ...
> tsc2007-$(CONFIG_TOUCHSCREEN_TSC2007_IIO) += tsc2007_iio.o

Ah, ok. Well, we tried to make it without an explicit config option
but it does not hurt to have one.

Your proposal works fine for 3 out of the 4 possible combinations.

I think it is unlikely that the combination TOUCHSCREEN_TSC2007=y IIO=m
is needed at all (we configure as much as possible as =m in our kernel).

Patch v9 will come next (where I have also moved this iio driver
patch to be 8/8).

BR and thanks,
Nikolaus