linux-kernel - Re: [PATCH v4 07/20] futex: Introduce throughput-optimized (TP) futexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 05:17:37 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Waiman Long <longman@...hat.com>
Cc:     kbuild-all@...org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Mike Galbraith <umgwanakikbuti@...il.com>,
        Scott J Norton <scott.norton@....com>,
        Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v4 07/20] futex: Introduce throughput-optimized (TP)
 futexes

Hi Waiman,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.10-rc1 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Waiman-Long/futex-Introducing-throughput-optimized-TP-futexes/20161230-020021
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

>> kernel/futex.c:3419: warning: No description found for parameter 'uaddr'
>> kernel/futex.c:3419: warning: No description found for parameter 'vpid'
>> kernel/futex.c:3419: warning: No description found for parameter 'puval'
>> kernel/futex.c:3419: warning: No description found for parameter 'waiter'
   kernel/futex.c:3456: warning: No description found for parameter 'uaddr'
   kernel/futex.c:3456: warning: No description found for parameter 'vpid'
   kernel/futex.c:3456: warning: No description found for parameter 'puval'

vim +/uaddr +3419 kernel/futex.c

  3403	 * The HB fs_lock should NOT be held while calling this function.
  3404	 * The flag bits are ignored in the trylock.
  3405	 *
  3406	 * If waiter is true
  3407	 * then
  3408	 *   don't preserve the flag bits;
  3409	 * else
  3410	 *   preserve the flag bits
  3411	 * endif
  3412	 *
  3413	 * Return: 1 if lock acquired;
  3414	 *	   0 if lock acquisition failed;
  3415	 *	   -EFAULT if an error happened.
  3416	 */
  3417	static inline int futex_trylock(u32 __user *uaddr, const u32 vpid, u32 *puval,
  3418					const bool waiter)
> 3419	{
  3420		u32 uval, flags = 0;
  3421	
  3422		if (unlikely(get_futex_value(puval, uaddr)))
  3423			return -EFAULT;
  3424	
  3425		uval = *puval;
  3426	
  3427		if (uval & FUTEX_TID_MASK)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (6457 bytes)