linux-kernel - Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Dec 2016 07:29:40 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Kenneth Lee <liguozhu@...ilicon.com>
Cc:     dledford@...hat.com, sean.hefty@...el.com,
        hal.rosenstock@...il.com, robin.murphy@....com, jroedel@...e.de,
        egtvedt@...fundet.no, vgupta@...opsys.com,
        dave.hansen@...ux.intel.com, lstoakes@...il.com, krzk@...nel.org,
        sebott@...ux.vnet.ibm.com, markb@...lanox.com,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

On Thu, Dec 29, 2016 at 10:24:43AM +0800, Kenneth Lee wrote:
> There are two bugfixes in this patch:
>
> 1. When the execution go to the ib_umem_odp_get() path, pid should be put
>    back.
> 2. When the memory allocation fail, the pid also should be put back before
>    exit.
>
> Signed-off-by: Kenneth Lee <liguozhu@...ilicon.com>

Hi Kenneth,

Thank you for resubmitting it. This fix is important and no doubts that
it will be accepted, however you need to improve the patch a little bit
more.

CAn you please resubmit it according to Documentation/SubmittingPatches
and reviewers feedback?

Haggai's Reviewed-by tag, Fixes, changelog, version in title and
proper title (see it in git log for this subsystems).

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)