linux-kernel - Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred device for ppmu device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 21:00:48 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     MyungJoo Ham <myungjoo.ham@...il.com>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM list <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Linux Samsung SoC <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred
 device for ppmu device

2016-12-30 19:35 GMT+09:00 MyungJoo Ham <myungjoo.ham@...sung.com>:
> On Wed, Dec 28, 2016 at 8:56 PM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
>> This patch just adds the simple log to show the PPMU device's registration
>> during the kernel booting.
>>
>> Cc: Kukjin Kim <kgene@...nel.org>
>> Cc: Krzysztof Kozlowski <krzk@...nel.org>
>> Cc: Javier Martinez Canillas <javier@....samsung.com>
>> Cc: linux-samsung-soc@...r.kernel.org
>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>> ---
>>  drivers/devfreq/event/exynos-ppmu.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
>> index fb3706faf5bd..9b5294d0bff4 100644
>> --- a/drivers/devfreq/event/exynos-ppmu.c
>> +++ b/drivers/devfreq/event/exynos-ppmu.c
>> @@ -591,7 +591,7 @@ static int exynos_ppmu_parse_dt(struct platform_device *pdev,
>>         info->ppmu.clk = devm_clk_get(dev, "ppmu");
>>         if (IS_ERR(info->ppmu.clk)) {
>>                 info->ppmu.clk = NULL;
>> -               dev_warn(dev, "cannot get PPMU clock\n");
>> +               dev_dbg(dev, "cannot get PPMU clock\n");
>
> Do you really want not to emit warning with a clock not found?

The clock is now optional on the exynos-bus.c driver. But we better to
keep the warning message. Instead, I'll try to add the clock to PPMU
which is missing the clock.

I'll send the next version.

[snip]

-- 
Best Regards,
Chanwoo Choi