linux-kernel - Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Jan 2017 16:26:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ozgur Karatas <okaratas@...ber.fsf.org>
Cc:     Scott Matheina <scott@...heina.com>,
        "thomas.petazzoni@...e-electrons.com" 
        <thomas.petazzoni@...e-electrons.com>,
        "noralf@...nnes.org" <noralf@...nnes.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay

On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote:
> 19.12.2016, 08:35, "Greg KH" <gregkh@...uxfoundation.org>:
> > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote:
> >>  These changes where identified by checkpatch.pl as needed changes to
> >>  align the code with the linux development coding style. The several
> >>  lines of text where aligned with the precending parenthesis.
> >>
> >>  Signed-off-by: Scott Matheina <scott@...heina.com>
> >>
> >>   Changes to be committed:
> >>          modified: drivers/staging/fbtft/fb_agm1264k-fl.c
> >
> > Why are these lines in the changelog text?
> 
> I checked with checkpatch script to code and give a some errors.
> So, the code have to "udelay(20)".
> 
> udelay(20);
> 
> I read to Documentation/timers/timers-howto.txt and
> this line incorrect, usleep_range need must be add defined U_DELAY and fixed.
> 
> udelay(U_DELAY, U_DELAY + 10);
> 
> finally:
> 
> $ checkpatch.pl  drivers/staging/fbtft/fb_agm1264k-fl.c  | grep total
> total: 0 errors
> 
> Signed-off-by: Ozgur Karatas <okaratas@...ber.fsf.org>
> 
> ---
>  drivers/staging/fbtft/fb_agm1264k-fl.c | 31 ++++++++++++-------------------
>  1 file changed, 12 insertions(+), 19 deletions(-)

You do realize there's nothing I can do with this patch as-is, right?
Please fix up the changelog text and resend it properly if you wish to
have it included.

thanks,

greg k-h